Allow an empty subject#56
Merged
LKaemmerling merged 1 commit intoMar 13, 2018
Merged
Conversation
Contributor
Author
|
Also, sorry about the PR spam - I've just been working a lot with this today and came across a few things - thanks for maintaining the package! |
Collaborator
|
Nice catch! Thank you! OT: Why would someone doesn't set a subject for a notification? |
Contributor
Author
|
My current client wanted to ditch the subject and just have what content of the chat post was - so had to work out how to remove it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only required parameter of the
OneSignalMessageshould be the body / contents. However, due to how the subject was previously added in thetoArray()method, OneSignal would throw an error due to an empty subject.Let's see some code.
Here you can see I am not setting the subject. Now let's look at the
toArray()method:OneSignal throws an error if you provide an empty value for the subject as above:
This PR implements a new method called
subjectToArray()which will only return the language / value key pair if there is a subject set - otherwise an empty array is returned. This fixes the above OneSignal error.